Apple changed the name of their operating system from OS X to macOS a number of years ago. This was overdue!
As per issue #10311
* refactor(osx): rename `osx` plugin to `macos`
* refactor(macos): Add symbolic link from old `osx` plugin name.
* Remove older shpotify code from the macOS plugin
* Add Shpotify 2.0.1 from the upstream repository at https://github.com/hnarayanan/shpotify/releases/tag/2.0.1
* Wrap the Shpotify script in a function and import into the macOS plugin
* Fix import path of the shpotify script
* Add shpotify permission notice in the macos plugin rREADME
* Merge with the upstream shpotify project
- Fix playlist playback
- Add a 'stop' command
Added playlist feature for the itunes command:
if a variable is passed and is valid - will play the playlist
if a variable is passed and is invalid(no such playlist) - will stop all playing
if no variable is passed will print all playlists available on the host
* Improve UX for Spotify commands in osx plugin
Spotify command UX is a bit weak for people who live and work almost entirely in shells.
- `spotify quit` should not open Spotify if it is not already running. Should confirm that Spotify is indeed not running.
- `spotify quit` should not blow away the user's shell once Spotify is quit. This can be a disruption to work flow.
This PR looks to add a few little checks which will help improve this experience.
This PR also adds a space to line 477 between `break` and `;;` for consistency. Doesn't seem like a big enough change to put in its own PR.
* Rearranging output as per peer feedback
* osx plugin's spotify: change quitting w/ closing
Closing is more idiomatic English.
Added function to display the song you're currently listening to in iTunes
Fixed indent
Indentation on line 169 was squiffy
Fixed spelling
Removed unnecessary wording to make function more succinct.
Highlighting of Artist and Track
Changed the highlighting of the Track and Artist in yellow to make use of Prompt Expansion Colors
Added shuffle functionality to the itunes command in the OSX plugin.
iTunes 12 doesn't support setting the "shuffle" property on the playlist
from what I've read, so this simulates the user interacting with the
iTunes interface. The toggle option "clicks" the shuffle button in the
Now Playing area. This has the effect of toggling the shuffle setting on
whatever is currently playing. The on and off options use the Shuffle
menu bar items.
Usage: itunes shuffle [on|off|toggle]
I have been continually having problems with the "trash" function provided by the osx plugin, getting this error:
trash:local:2: not valid in this context:
It seems like adding quotes around the assignment in [osx.plugin.zsh#L142](https://github.com/robbyrussell/oh-my-zsh/blob/master/plugins/osx/osx.plugin.zsh#L142) fixed my problem.
Does this look good to you? Thanks!
