Use constants to define methods

This commit is contained in:
Marc Hagen 2022-11-23 12:03:02 +01:00
parent b3098f8013
commit abddfc4a64
No known key found for this signature in database
3 changed files with 30 additions and 16 deletions

View file

@ -24,6 +24,13 @@ class LookingGlass
public const SESSION_ERROR_MESSAGE = 'error_message'; public const SESSION_ERROR_MESSAGE = 'error_message';
public const SESSION_CSRF = 'CSRF'; public const SESSION_CSRF = 'CSRF';
public const METHOD_PING = 'ping';
public const METHOD_PING6 = 'ping6';
public const METHOD_MTR = 'mtr';
public const METHOD_MTR6 = 'mtr6';
public const METHOD_TRACEROUTE = 'traceroute';
public const METHOD_TRACEROUTE6 = 'traceroute6';
private const MTR_COUNT = 10; private const MTR_COUNT = 10;
/** /**

View file

@ -28,24 +28,24 @@ if (isset($_SESSION[LookingGlass::SESSION_TARGET_HOST]) &&
unset($_SESSION[LookingGlass::SESSION_CALL_BACKEND]); unset($_SESSION[LookingGlass::SESSION_CALL_BACKEND]);
switch ($_SESSION['METHOD']) { switch ($_SESSION[LookingGlass::SESSION_TARGET_METHOD]) {
case 'ping': case LookingGlass::METHOD_PING:
LookingGlass::ping($_SESSION['TARGET']); LookingGlass::ping($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
case 'ping6': case LookingGlass::METHOD_PING6:
LookingGlass::ping6($_SESSION['TARGET']); LookingGlass::ping6($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
case 'mtr': case LookingGlass::METHOD_MTR:
LookingGlass::mtr($_SESSION['TARGET']); LookingGlass::mtr($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
case 'mtr6': case LookingGlass::METHOD_MTR6:
LookingGlass::mtr6($_SESSION['TARGET']); LookingGlass::mtr6($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
case 'traceroute': case LookingGlass::METHOD_TRACEROUTE:
LookingGlass::traceroute($_SESSION['TARGET']); LookingGlass::traceroute($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
case 'traceroute6': case LookingGlass::METHOD_TRACEROUTE6:
LookingGlass::traceroute6($_SESSION['TARGET']); LookingGlass::traceroute6($_SESSION[LookingGlass::SESSION_TARGET_HOST]);
break; break;
} }
} }

View file

@ -1,5 +1,5 @@
<?php <?php declare(strict_types=1);
declare(strict_types=1); use Hybula\LookingGlass;
// Define the HTML title; // Define the HTML title;
const LG_TITLE = 'Looking Glass'; const LG_TITLE = 'Looking Glass';
@ -36,7 +36,14 @@ const LG_IPV4 = '127.0.0.1';
const LG_IPV6 = '::1'; const LG_IPV6 = '::1';
// Define the methods that can be used by visitors to test it out; // Define the methods that can be used by visitors to test it out;
const LG_METHODS = ['ping', 'ping6', 'mtr', 'mtr6', 'traceroute', 'traceroute6']; const LG_METHODS = [
LookingGlass::METHOD_PING,
LookingGlass::METHOD_PING6,
LookingGlass::METHOD_MTR,
LookingGlass::METHOD_MTR6,
LookingGlass::METHOD_TRACEROUTE,
LookingGlass::METHOD_TRACEROUTE6,
];
// Define other looking glasses, this is useful if you have multiple networks and looking glasses; // Define other looking glasses, this is useful if you have multiple networks and looking glasses;
const LG_LOCATIONS = [ const LG_LOCATIONS = [