mirror of
https://github.com/immich-app/immich.git
synced 2025-01-09 21:36:46 +01:00
8edc2fb46f
* rename thumbnail config update target paths, fix tests rename to image settings replace legacy enum better typing update sql update api remove config option fix * update docs * update other thumbnail configs in migration * keep legacy enum for now * fix jumbled job names * fix jumbled job names in tests * rename thumbhash job * rename dto * fix tests * preserve order * remove unused import * keep old fields in dto, marked deprecated * update sql --------- Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
220 lines
8.7 KiB
TypeScript
220 lines
8.7 KiB
TypeScript
import { when } from 'jest-when';
|
|
import { AssetRejectReason, AssetUploadAction } from 'src/dtos/asset-v1-response.dto';
|
|
import { CreateAssetDto } from 'src/dtos/asset-v1.dto';
|
|
import { ASSET_CHECKSUM_CONSTRAINT, AssetEntity, AssetType } from 'src/entities/asset.entity';
|
|
import { ExifEntity } from 'src/entities/exif.entity';
|
|
import { IAssetRepositoryV1 } from 'src/interfaces/asset-v1.interface';
|
|
import { IAssetRepository } from 'src/interfaces/asset.interface';
|
|
import { IJobRepository, JobName } from 'src/interfaces/job.interface';
|
|
import { ILibraryRepository } from 'src/interfaces/library.interface';
|
|
import { IStorageRepository } from 'src/interfaces/storage.interface';
|
|
import { IUserRepository } from 'src/interfaces/user.interface';
|
|
import { AssetServiceV1 } from 'src/services/asset-v1.service';
|
|
import { assetStub } from 'test/fixtures/asset.stub';
|
|
import { authStub } from 'test/fixtures/auth.stub';
|
|
import { fileStub } from 'test/fixtures/file.stub';
|
|
import { IAccessRepositoryMock, newAccessRepositoryMock } from 'test/repositories/access.repository.mock';
|
|
import { newAssetRepositoryMock } from 'test/repositories/asset.repository.mock';
|
|
import { newJobRepositoryMock } from 'test/repositories/job.repository.mock';
|
|
import { newLibraryRepositoryMock } from 'test/repositories/library.repository.mock';
|
|
import { newStorageRepositoryMock } from 'test/repositories/storage.repository.mock';
|
|
import { newUserRepositoryMock } from 'test/repositories/user.repository.mock';
|
|
import { QueryFailedError } from 'typeorm';
|
|
|
|
const _getCreateAssetDto = (): CreateAssetDto => {
|
|
const createAssetDto = new CreateAssetDto();
|
|
createAssetDto.deviceAssetId = 'deviceAssetId';
|
|
createAssetDto.deviceId = 'deviceId';
|
|
createAssetDto.fileCreatedAt = new Date('2022-06-19T23:41:36.910Z');
|
|
createAssetDto.fileModifiedAt = new Date('2022-06-19T23:41:36.910Z');
|
|
createAssetDto.isFavorite = false;
|
|
createAssetDto.isArchived = false;
|
|
createAssetDto.duration = '0:00:00.000000';
|
|
createAssetDto.libraryId = 'libraryId';
|
|
|
|
return createAssetDto;
|
|
};
|
|
|
|
const _getAsset_1 = () => {
|
|
const asset_1 = new AssetEntity();
|
|
|
|
asset_1.id = 'id_1';
|
|
asset_1.ownerId = 'user_id_1';
|
|
asset_1.deviceAssetId = 'device_asset_id_1';
|
|
asset_1.deviceId = 'device_id_1';
|
|
asset_1.type = AssetType.VIDEO;
|
|
asset_1.originalPath = 'fake_path/asset_1.jpeg';
|
|
asset_1.previewPath = '';
|
|
asset_1.fileModifiedAt = new Date('2022-06-19T23:41:36.910Z');
|
|
asset_1.fileCreatedAt = new Date('2022-06-19T23:41:36.910Z');
|
|
asset_1.updatedAt = new Date('2022-06-19T23:41:36.910Z');
|
|
asset_1.isFavorite = false;
|
|
asset_1.isArchived = false;
|
|
asset_1.thumbnailPath = '';
|
|
asset_1.encodedVideoPath = '';
|
|
asset_1.duration = '0:00:00.000000';
|
|
asset_1.exifInfo = new ExifEntity();
|
|
asset_1.exifInfo.latitude = 49.533_547;
|
|
asset_1.exifInfo.longitude = 10.703_075;
|
|
return asset_1;
|
|
};
|
|
|
|
describe('AssetService', () => {
|
|
let sut: AssetServiceV1;
|
|
let accessMock: IAccessRepositoryMock;
|
|
let assetRepositoryMockV1: jest.Mocked<IAssetRepositoryV1>;
|
|
let assetMock: jest.Mocked<IAssetRepository>;
|
|
let jobMock: jest.Mocked<IJobRepository>;
|
|
let libraryMock: jest.Mocked<ILibraryRepository>;
|
|
let storageMock: jest.Mocked<IStorageRepository>;
|
|
let userMock: jest.Mocked<IUserRepository>;
|
|
|
|
beforeEach(() => {
|
|
assetRepositoryMockV1 = {
|
|
get: jest.fn(),
|
|
getAllByUserId: jest.fn(),
|
|
getDetectedObjectsByUserId: jest.fn(),
|
|
getLocationsByUserId: jest.fn(),
|
|
getSearchPropertiesByUserId: jest.fn(),
|
|
getAssetsByChecksums: jest.fn(),
|
|
getExistingAssets: jest.fn(),
|
|
getByOriginalPath: jest.fn(),
|
|
};
|
|
|
|
accessMock = newAccessRepositoryMock();
|
|
assetMock = newAssetRepositoryMock();
|
|
jobMock = newJobRepositoryMock();
|
|
libraryMock = newLibraryRepositoryMock();
|
|
storageMock = newStorageRepositoryMock();
|
|
userMock = newUserRepositoryMock();
|
|
|
|
sut = new AssetServiceV1(accessMock, assetRepositoryMockV1, assetMock, jobMock, libraryMock, storageMock, userMock);
|
|
|
|
when(assetRepositoryMockV1.get)
|
|
.calledWith(assetStub.livePhotoStillAsset.id)
|
|
.mockResolvedValue(assetStub.livePhotoStillAsset);
|
|
when(assetRepositoryMockV1.get)
|
|
.calledWith(assetStub.livePhotoMotionAsset.id)
|
|
.mockResolvedValue(assetStub.livePhotoMotionAsset);
|
|
});
|
|
|
|
describe('uploadFile', () => {
|
|
it('should handle a file upload', async () => {
|
|
const assetEntity = _getAsset_1();
|
|
const file = {
|
|
uuid: 'random-uuid',
|
|
originalPath: 'fake_path/asset_1.jpeg',
|
|
mimeType: 'image/jpeg',
|
|
checksum: Buffer.from('file hash', 'utf8'),
|
|
originalName: 'asset_1.jpeg',
|
|
size: 42,
|
|
};
|
|
const dto = _getCreateAssetDto();
|
|
|
|
assetMock.create.mockResolvedValue(assetEntity);
|
|
accessMock.library.checkOwnerAccess.mockResolvedValue(new Set([dto.libraryId!]));
|
|
|
|
await expect(sut.uploadFile(authStub.user1, dto, file)).resolves.toEqual({ duplicate: false, id: 'id_1' });
|
|
|
|
expect(assetMock.create).toHaveBeenCalled();
|
|
expect(userMock.updateUsage).toHaveBeenCalledWith(authStub.user1.user.id, file.size);
|
|
expect(storageMock.utimes).toHaveBeenCalledWith(
|
|
file.originalPath,
|
|
expect.any(Date),
|
|
new Date(dto.fileModifiedAt),
|
|
);
|
|
});
|
|
|
|
it('should handle a duplicate', async () => {
|
|
const file = {
|
|
uuid: 'random-uuid',
|
|
originalPath: 'fake_path/asset_1.jpeg',
|
|
mimeType: 'image/jpeg',
|
|
checksum: Buffer.from('file hash', 'utf8'),
|
|
originalName: 'asset_1.jpeg',
|
|
size: 0,
|
|
};
|
|
const dto = _getCreateAssetDto();
|
|
const error = new QueryFailedError('', [], new Error('unique key violation'));
|
|
(error as any).constraint = ASSET_CHECKSUM_CONSTRAINT;
|
|
|
|
assetMock.create.mockRejectedValue(error);
|
|
assetRepositoryMockV1.getAssetsByChecksums.mockResolvedValue([_getAsset_1()]);
|
|
accessMock.library.checkOwnerAccess.mockResolvedValue(new Set([dto.libraryId!]));
|
|
|
|
await expect(sut.uploadFile(authStub.user1, dto, file)).resolves.toEqual({ duplicate: true, id: 'id_1' });
|
|
|
|
expect(jobMock.queue).toHaveBeenCalledWith({
|
|
name: JobName.DELETE_FILES,
|
|
data: { files: ['fake_path/asset_1.jpeg', undefined, undefined] },
|
|
});
|
|
expect(userMock.updateUsage).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should handle a live photo', async () => {
|
|
const dto = _getCreateAssetDto();
|
|
const error = new QueryFailedError('', [], new Error('unique key violation'));
|
|
(error as any).constraint = ASSET_CHECKSUM_CONSTRAINT;
|
|
|
|
assetMock.create.mockResolvedValueOnce(assetStub.livePhotoMotionAsset);
|
|
assetMock.create.mockResolvedValueOnce(assetStub.livePhotoStillAsset);
|
|
accessMock.library.checkOwnerAccess.mockResolvedValue(new Set([dto.libraryId!]));
|
|
|
|
await expect(
|
|
sut.uploadFile(authStub.user1, dto, fileStub.livePhotoStill, fileStub.livePhotoMotion),
|
|
).resolves.toEqual({
|
|
duplicate: false,
|
|
id: 'live-photo-still-asset',
|
|
});
|
|
|
|
expect(jobMock.queue.mock.calls).toEqual([
|
|
[
|
|
{
|
|
name: JobName.METADATA_EXTRACTION,
|
|
data: { id: assetStub.livePhotoMotionAsset.id, source: 'upload' },
|
|
},
|
|
],
|
|
[{ name: JobName.METADATA_EXTRACTION, data: { id: assetStub.livePhotoStillAsset.id, source: 'upload' } }],
|
|
]);
|
|
expect(userMock.updateUsage).toHaveBeenCalledWith(authStub.user1.user.id, 111);
|
|
expect(storageMock.utimes).toHaveBeenCalledWith(
|
|
fileStub.livePhotoStill.originalPath,
|
|
expect.any(Date),
|
|
new Date(dto.fileModifiedAt),
|
|
);
|
|
expect(storageMock.utimes).toHaveBeenCalledWith(
|
|
fileStub.livePhotoMotion.originalPath,
|
|
expect.any(Date),
|
|
new Date(dto.fileModifiedAt),
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('bulkUploadCheck', () => {
|
|
it('should accept hex and base64 checksums', async () => {
|
|
const file1 = Buffer.from('d2947b871a706081be194569951b7db246907957', 'hex');
|
|
const file2 = Buffer.from('53be335e99f18a66ff12e9a901c7a6171dd76573', 'hex');
|
|
|
|
assetRepositoryMockV1.getAssetsByChecksums.mockResolvedValue([
|
|
{ id: 'asset-1', checksum: file1 },
|
|
{ id: 'asset-2', checksum: file2 },
|
|
]);
|
|
|
|
await expect(
|
|
sut.bulkUploadCheck(authStub.admin, {
|
|
assets: [
|
|
{ id: '1', checksum: file1.toString('hex') },
|
|
{ id: '2', checksum: file2.toString('base64') },
|
|
],
|
|
}),
|
|
).resolves.toEqual({
|
|
results: [
|
|
{ id: '1', assetId: 'asset-1', action: AssetUploadAction.REJECT, reason: AssetRejectReason.DUPLICATE },
|
|
{ id: '2', assetId: 'asset-2', action: AssetUploadAction.REJECT, reason: AssetRejectReason.DUPLICATE },
|
|
],
|
|
});
|
|
|
|
expect(assetRepositoryMockV1.getAssetsByChecksums).toHaveBeenCalledWith(authStub.admin.user.id, [file1, file2]);
|
|
});
|
|
});
|
|
});
|