c-l/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-04 02:46:47 +01:00
Code Releases Activity

fix(server): missing metadata extraction job (#2586)

Browse source 
* fix(server): missing metadata extraction job

* format

* fix test

* fix test

* Added source to upload

* fix test

* OK! CODE COVERAGE
This commit is contained in:
Alex 2023-05-27 16:49:57 -05:00 committed by GitHub
parent fd4357cf23
commit fc2455be80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server/apps/immich/src/api-v1/asset/asset.core.ts
View file

@ -43,7 +43,7 @@ export class AssetCore {
sidecarPath: sidecarFile?.originalPath || null, sidecarPath: sidecarFile?.originalPath || null,
}); });
await this.jobRepository.queue({ name: JobName.GENERATE_JPEG_THUMBNAIL, data: { id: asset.id } }); await this.jobRepository.queue({ name: JobName.METADATA_EXTRACTION, data: { id: asset.id, source: 'upload' } });
if (asset.type === AssetType.VIDEO) { if (asset.type === AssetType.VIDEO) {
await this.jobRepository.queue({ name: JobName.VIDEO_CONVERSION, data: { id: asset.id } }); await this.jobRepository.queue({ name: JobName.VIDEO_CONVERSION, data: { id: asset.id } });
} }

9
server/apps/immich/src/api-v1/asset/asset.service.spec.ts
View file

@ -328,9 +328,14 @@ describe('AssetService', () => {
}); });
expect(jobMock.queue.mock.calls).toEqual([ expect(jobMock.queue.mock.calls).toEqual([
[{ name: JobName.GENERATE_JPEG_THUMBNAIL, data: { id: assetEntityStub.livePhotoMotionAsset.id } }], [
{
name: JobName.METADATA_EXTRACTION,
data: { id: assetEntityStub.livePhotoMotionAsset.id, source: 'upload' },
},
],
[{ name: JobName.VIDEO_CONVERSION, data: { id: assetEntityStub.livePhotoMotionAsset.id } }], [{ name: JobName.VIDEO_CONVERSION, data: { id: assetEntityStub.livePhotoMotionAsset.id } }],
[{ name: JobName.GENERATE_JPEG_THUMBNAIL, data: { id: assetEntityStub.livePhotoStillAsset.id } }], [{ name: JobName.METADATA_EXTRACTION, data: { id: assetEntityStub.livePhotoStillAsset.id, source: 'upload' } }],
]); ]);
}); });
}); });

1
server/libs/domain/src/job/job.interface.ts
View file

@ -19,6 +19,7 @@ export interface IFaceThumbnailJob extends IAssetFaceJob {
export interface IEntityJob extends IBaseJob { export interface IEntityJob extends IBaseJob {
id: string; id: string;
source?: string;
} }
export interface IBulkEntityJob extends IBaseJob { export interface IBulkEntityJob extends IBaseJob {

6
server/libs/domain/src/job/job.service.ts
View file

@ -110,6 +110,12 @@ export class JobService {
await this.jobRepository.queue({ name: JobName.STORAGE_TEMPLATE_MIGRATION_SINGLE, data: item.data }); await this.jobRepository.queue({ name: JobName.STORAGE_TEMPLATE_MIGRATION_SINGLE, data: item.data });
break; break;
case JobName.STORAGE_TEMPLATE_MIGRATION_SINGLE:
if (item.data.source === 'upload') {
await this.jobRepository.queue({ name: JobName.GENERATE_JPEG_THUMBNAIL, data: item.data });
}
break;
case JobName.GENERATE_JPEG_THUMBNAIL: { case JobName.GENERATE_JPEG_THUMBNAIL: {
await this.jobRepository.queue({ name: JobName.GENERATE_WEBP_THUMBNAIL, data: item.data }); await this.jobRepository.queue({ name: JobName.GENERATE_WEBP_THUMBNAIL, data: item.data });
await this.jobRepository.queue({ name: JobName.CLASSIFY_IMAGE, data: item.data }); await this.jobRepository.queue({ name: JobName.CLASSIFY_IMAGE, data: item.data });

2
server/package.json
View file

@ -141,7 +141,7 @@
"./libs/domain/": { "./libs/domain/": {
"branches": 80, "branches": 80,
"functions": 87, "functions": 87,
"lines": 94, "lines": 93.8,
"statements": 93 "statements": 93
} }
}, },