From 86f780871c470c6bfc33cce10e427f9ad82cc2b7 Mon Sep 17 00:00:00 2001
From: Alex <alex.tran1502@gmail.com>
Date: Mon, 15 Aug 2022 19:11:08 -0500
Subject: [PATCH] Fixed different lettercases in email create different user
 (#470)

* Fixed different lettercases in email create different user

* Fixed test
---
 server/apps/immich/src/api-v1/auth/auth.controller.ts    | 9 +++++----
 .../immich/src/api-v1/auth/dto/login-credential.dto.ts   | 2 ++
 server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts    | 2 ++
 .../apps/immich/src/api-v1/user/dto/create-user.dto.ts   | 2 ++
 server/apps/immich/src/api-v1/user/user.controller.ts    | 4 +++-
 5 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/server/apps/immich/src/api-v1/auth/auth.controller.ts b/server/apps/immich/src/api-v1/auth/auth.controller.ts
index ea7d68f3ea..031c39610d 100644
--- a/server/apps/immich/src/api-v1/auth/auth.controller.ts
+++ b/server/apps/immich/src/api-v1/auth/auth.controller.ts
@@ -25,7 +25,7 @@ export class AuthController {
 
   @Post('/login')
   async login(
-    @Body(ValidationPipe) loginCredential: LoginCredentialDto,
+    @Body(new ValidationPipe({ transform: true })) loginCredential: LoginCredentialDto,
     @Res() response: Response,
   ): Promise<LoginResponseDto> {
     const loginResponse = await this.authService.login(loginCredential);
@@ -42,7 +42,9 @@ export class AuthController {
 
   @Post('/admin-sign-up')
   @ApiBadRequestResponse({ description: 'The server already has an admin' })
-  async adminSignUp(@Body(ValidationPipe) signUpCredential: SignUpDto): Promise<AdminSignupResponseDto> {
+  async adminSignUp(
+    @Body(new ValidationPipe({ transform: true })) signUpCredential: SignUpDto,
+  ): Promise<AdminSignupResponseDto> {
     return await this.authService.adminSignUp(signUpCredential);
   }
 
@@ -61,8 +63,7 @@ export class AuthController {
 
     const status = new LogoutResponseDto(true);
 
-    response.send(status)
+    response.send(status);
     return status;
   }
-
 }
diff --git a/server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts b/server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts
index 29ba5cf026..7426303528 100644
--- a/server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts
+++ b/server/apps/immich/src/api-v1/auth/dto/login-credential.dto.ts
@@ -1,9 +1,11 @@
 import { ApiProperty } from '@nestjs/swagger';
+import { Transform } from 'class-transformer';
 import { IsNotEmpty } from 'class-validator';
 
 export class LoginCredentialDto {
   @IsNotEmpty()
   @ApiProperty({ example: 'testuser@email.com' })
+  @Transform(({ value }) => value?.toLowerCase())
   email!: string;
 
   @IsNotEmpty()
diff --git a/server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts b/server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts
index d8dbd8a8df..3358ddac31 100644
--- a/server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts
+++ b/server/apps/immich/src/api-v1/auth/dto/sign-up.dto.ts
@@ -1,9 +1,11 @@
 import { ApiProperty } from '@nestjs/swagger';
+import { Transform } from 'class-transformer';
 import { IsNotEmpty, IsEmail } from 'class-validator';
 
 export class SignUpDto {
   @IsEmail()
   @ApiProperty({ example: 'testuser@email.com' })
+  @Transform(({ value }) => value?.toLowerCase())
   email!: string;
 
   @IsNotEmpty()
diff --git a/server/apps/immich/src/api-v1/user/dto/create-user.dto.ts b/server/apps/immich/src/api-v1/user/dto/create-user.dto.ts
index 13facfad34..d18f0a3237 100644
--- a/server/apps/immich/src/api-v1/user/dto/create-user.dto.ts
+++ b/server/apps/immich/src/api-v1/user/dto/create-user.dto.ts
@@ -1,8 +1,10 @@
 import { ApiProperty } from '@nestjs/swagger';
+import { Transform } from 'class-transformer';
 import { IsNotEmpty, IsEmail } from 'class-validator';
 
 export class CreateUserDto {
   @IsEmail()
+  @Transform(({ value }) => value?.toLowerCase())
   @ApiProperty({ example: 'testuser@email.com' })
   email!: string;
 
diff --git a/server/apps/immich/src/api-v1/user/user.controller.ts b/server/apps/immich/src/api-v1/user/user.controller.ts
index 9e433c0076..e2eff4418c 100644
--- a/server/apps/immich/src/api-v1/user/user.controller.ts
+++ b/server/apps/immich/src/api-v1/user/user.controller.ts
@@ -61,7 +61,9 @@ export class UserController {
   @ApiBearerAuth()
   @UseGuards(AdminRolesGuard)
   @Post()
-  async createUser(@Body(ValidationPipe) createUserDto: CreateUserDto): Promise<UserResponseDto> {
+  async createUser(
+    @Body(new ValidationPipe({ transform: true })) createUserDto: CreateUserDto,
+  ): Promise<UserResponseDto> {
     return await this.userService.createUser(createUserDto);
   }