c-l/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-01-01 08:31:59 +00:00
Code Releases Activity

fixed referencing uninitialized orientation

Browse source
This commit is contained in:
mertalev 2024-11-07 18:12:34 -05:00
parent 973b146d06
commit 7d5294f7ef
No known key found for this signature in database
GPG key ID: CA85EF6600C9E8AD
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
mobile/lib/pages/common/native_video_viewer.page.dart
View file

@ -13,6 +13,7 @@ import 'package:immich_mobile/services/api.service.dart';
import 'package:immich_mobile/services/app_settings.service.dart'; import 'package:immich_mobile/services/app_settings.service.dart';
import 'package:immich_mobile/services/asset.service.dart'; import 'package:immich_mobile/services/asset.service.dart';
import 'package:immich_mobile/utils/hooks/interval_hook.dart'; import 'package:immich_mobile/utils/hooks/interval_hook.dart';
import 'package:immich_mobile/utils/throttle.dart';
import 'package:immich_mobile/widgets/asset_viewer/custom_video_player_controls.dart'; import 'package:immich_mobile/widgets/asset_viewer/custom_video_player_controls.dart';
import 'package:logging/logging.dart'; import 'package:logging/logging.dart';
import 'package:native_video_player/native_video_player.dart'; import 'package:native_video_player/native_video_player.dart';
@ -71,18 +72,14 @@ class NativeVideoViewerPage extends HookConsumerWidget {
if (asset.exifInfo != null) { if (asset.exifInfo != null) {
orientatedWidth = asset.orientatedWidth?.toDouble(); orientatedWidth = asset.orientatedWidth?.toDouble();
orientatedHeight = asset.orientatedHeight?.toDouble(); orientatedHeight = asset.orientatedHeight?.toDouble();
} } else if (localEntity != null) {
if (orientatedWidth == null && localEntity != null) {
final entity = await localEntity; final entity = await localEntity;
if (entity != null) { if (entity != null) {
asset.local = entity; asset.local = entity;
orientatedWidth = entity.orientatedWidth.toDouble(); orientatedWidth = entity.orientatedWidth.toDouble();
orientatedHeight = entity.orientatedHeight.toDouble(); orientatedHeight = entity.orientatedHeight.toDouble();
} }
} } else {
if (orientatedWidth == null) {
final entity = await ref.read(assetServiceProvider).loadExif(asset); final entity = await ref.read(assetServiceProvider).loadExif(asset);
orientatedWidth = entity.orientatedWidth?.toDouble(); orientatedWidth = entity.orientatedWidth?.toDouble();
orientatedHeight = entity.orientatedHeight?.toDouble(); orientatedHeight = entity.orientatedHeight?.toDouble();
@ -196,6 +193,8 @@ class NativeVideoViewerPage extends HookConsumerWidget {
}); });
// When the position changes, seek to the position // When the position changes, seek to the position
final seekThrottler =
useThrottler(interval: const Duration(milliseconds: 200));
ref.listen(videoPlayerControlsProvider.select((value) => value.position), ref.listen(videoPlayerControlsProvider.select((value) => value.position),
(_, position) { (_, position) {
final playerController = controller.value; final playerController = controller.value;
@ -212,7 +211,7 @@ class NativeVideoViewerPage extends HookConsumerWidget {
final int seek = (asset.duration * (position / 100.0)).inSeconds; final int seek = (asset.duration * (position / 100.0)).inSeconds;
if (seek != playbackInfo.position) { if (seek != playbackInfo.position) {
try { try {
playerController.seekTo(seek); seekThrottler.run(() => playerController.seekTo(seek));
} catch (error) { } catch (error) {
log.severe('Error seeking to position $position: $error'); log.severe('Error seeking to position $position: $error');
} }