c-l/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-03-01 15:11:21 +01:00
Code Releases Activity

fixes safe area issue with multiselect and adds overscroll on main timeline to select bottom (#1718)

Browse source
This commit is contained in:
martyfuhry 2023-02-10 01:02:26 -05:00 • committed by GitHub
parent b37162099e
commit 6e4ba6184b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
mobile/lib/modules/home/ui/asset_grid/immich_asset_grid.dart
View file

@ -189,6 +189,9 @@ class ImmichAssetGridState extends State<ImmichAssetGrid> {
} }
final listWidget = ScrollablePositionedList.builder( final listWidget = ScrollablePositionedList.builder(
padding: const EdgeInsets.only(
bottom: 220,
),
itemBuilder: _itemBuilder, itemBuilder: _itemBuilder,
itemPositionsListener: _itemPositionsListener, itemPositionsListener: _itemPositionsListener,
itemScrollController: _itemScrollController, itemScrollController: _itemScrollController,

28
mobile/lib/modules/home/views/home_page.dart
View file

@ -216,7 +216,6 @@ class HomePage extends HookConsumerWidget {
} }
return SafeArea( return SafeArea(
bottom: !multiselectEnabled.state,
top: true, top: true,
child: Stack( child: Stack(
children: [ children: [
@ -234,14 +233,17 @@ class HomePage extends HookConsumerWidget {
selectionActive: selectionEnabledHook.value, selectionActive: selectionEnabledHook.value,
), ),
if (selectionEnabledHook.value) if (selectionEnabledHook.value)
ControlBottomAppBar( SafeArea(
onShare: onShareAssets, bottom: true,
onFavorite: onFavoriteAssets, child: ControlBottomAppBar(
onDelete: onDelete, onShare: onShareAssets,
onAddToAlbum: onAddToAlbum, onFavorite: onFavoriteAssets,
albums: albums, onDelete: onDelete,
sharedAlbums: sharedAlbums, onAddToAlbum: onAddToAlbum,
onCreateNewAlbum: onCreateNewAlbum, albums: albums,
sharedAlbums: sharedAlbums,
onCreateNewAlbum: onCreateNewAlbum,
),
), ),
], ],
), ),
@ -249,11 +251,9 @@ class HomePage extends HookConsumerWidget {
} }
return Scaffold( return Scaffold(
appBar: multiselectEnabled.state appBar: HomePageAppBar(
? null onPopBack: reloadAllAsset,
: HomePageAppBar( ),
onPopBack: reloadAllAsset,
),
drawer: const ProfileDrawer(), drawer: const ProfileDrawer(),
body: buildBody(), body: buildBody(),
); );