c-l/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2024-12-28 06:31:58 +00:00
Code Releases Activity

fix(web): recent albums sort (#14545)

Browse source
This commit is contained in:
Michel Heusschen 2024-12-07 17:24:00 +01:00 committed by GitHub
parent e2b36476e7
commit 5e955a1b03
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
web/src/lib/components/shared-components/side-bar/recent-albums.spec.ts Normal file
View file

@ -0,0 +1,28 @@
import { sdkMock } from '$lib/__mocks__/sdk.mock';
import RecentAlbums from '$lib/components/shared-components/side-bar/recent-albums.svelte';
import { albumFactory } from '@test-data/factories/album-factory';
import { render, screen } from '@testing-library/svelte';
import { tick } from 'svelte';
describe('RecentAlbums component', () => {
it('sorts albums by most recently updated', async () => {
const albums = [
albumFactory.build({ updatedAt: '2024-01-01T00:00:00Z' }),
albumFactory.build({ updatedAt: '2024-01-09T00:00:01Z' }),
albumFactory.build({ updatedAt: '2024-01-10T00:00:00Z' }),
albumFactory.build({ updatedAt: '2024-01-09T00:00:00Z' }),
];
sdkMock.getAllAlbums.mockResolvedValueOnce([...albums]);
render(RecentAlbums);
expect(sdkMock.getAllAlbums).toBeCalledTimes(1);
await tick();
const links = screen.getAllByRole('link');
expect(links).toHaveLength(3);
expect(links[0]).toHaveAttribute('href', `/albums/${albums[2].id}`);
expect(links[1]).toHaveAttribute('href', `/albums/${albums[1].id}`);
expect(links[2]).toHaveAttribute('href', `/albums/${albums[3].id}`);
});
});

4
web/src/lib/components/shared-components/side-bar/recent-albums.svelte
View file

@ -10,9 +10,7 @@
onMount(async () => {
try {
const allAlbums = await getAllAlbums({});
albums = allAlbums
.sort((album1, album2) => (album1.lastModifiedAssetTimestamp! > album2.lastModifiedAssetTimestamp! ? 1 : 0))
.slice(0, 3);
albums = allAlbums.sort((a, b) => (a.updatedAt > b.updatedAt ? -1 : 1)).slice(0, 3);
} catch (error) {
handleError(error, $t('failed_to_load_assets'));
}