From 564ace3ddf56d391f5f5349c4b73212a1c7ab5ed Mon Sep 17 00:00:00 2001
From: bo0tzz <git@bo0tzz.me>
Date: Mon, 5 Sep 2022 16:51:45 +0200
Subject: [PATCH] Use runtime env var for login page message to lower web
 container startup time (#577)

* Use runtime env var for loginPageMessage

* Rename VITE_LOGIN_PAGE_MESSAGE to PUBLIC_LOGIN_PAGE_MESSAGE in .env.example

* Move docker image `npm run build` step into Dockerfile

* Remove comment from web Dockerfile
---
 docker/.env.example      | 4 ++--
 web/Dockerfile           | 5 ++---
 web/entrypoint.sh        | 1 -
 web/src/lib/constants.ts | 3 ++-
 4 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/docker/.env.example b/docker/.env.example
index 18c96c3534..be70ce5d11 100644
--- a/docker/.env.example
+++ b/docker/.env.example
@@ -61,6 +61,6 @@ MAPBOX_KEY=
 ####################################################################################
 
 # Custom message on the login page, should be written in HTML form.
-# For example VITE_LOGIN_PAGE_MESSAGE="This is a demo instance of Immich.<br><br>Email: <i>demo@demo.de</i><br>Password: <i>demo</i>"
+# For example PUBLIC_LOGIN_PAGE_MESSAGE="This is a demo instance of Immich.<br><br>Email: <i>demo@demo.de</i><br>Password: <i>demo</i>"
 
-VITE_LOGIN_PAGE_MESSAGE=
\ No newline at end of file
+PUBLIC_LOGIN_PAGE_MESSAGE=
\ No newline at end of file
diff --git a/web/Dockerfile b/web/Dockerfile
index b5db9c9e81..9986b8fce6 100644
--- a/web/Dockerfile
+++ b/web/Dockerfile
@@ -13,6 +13,8 @@ RUN npm ci
 
 COPY --chown=node:node . .
 
+RUN npm run build
+
 EXPOSE 3000
 
 FROM base AS dev
@@ -22,6 +24,3 @@ CMD ["npm", "run", "dev"]
 
 FROM base as prod
 ENV NODE_ENV=production
-
-
-# Issue build command in entrypoint.sh to capture user .env file instead of the builder .env file.
diff --git a/web/entrypoint.sh b/web/entrypoint.sh
index dc06f9b738..cabdaeb5d2 100644
--- a/web/entrypoint.sh
+++ b/web/entrypoint.sh
@@ -1,4 +1,3 @@
-npm run build
 if [ `id -u` -eq 0 ] && [ -n "$PUID" ] && [ -n "$PGID" ]; then
     exec setpriv --reuid $PUID --regid $PGID --clear-groups node /usr/src/app/build/index.js
 else
diff --git a/web/src/lib/constants.ts b/web/src/lib/constants.ts
index 7f09000e27..1cd049a622 100644
--- a/web/src/lib/constants.ts
+++ b/web/src/lib/constants.ts
@@ -1 +1,2 @@
-export const loginPageMessage: string = import.meta.env.VITE_LOGIN_PAGE_MESSAGE;
+import { env } from '$env/dynamic/public';
+export const loginPageMessage: string = env.PUBLIC_LOGIN_PAGE_MESSAGE;
\ No newline at end of file