1
0
Fork 0
mirror of https://github.com/ohmyzsh/ohmyzsh.git synced 2024-12-20 19:31:58 +00:00

contributing: improve PR section

This commit is contained in:
ncanceill 2015-10-16 23:23:38 +02:00 committed by Marc Cornellà
parent 5a031ce3e6
commit bc2ccdd812

View file

@ -72,11 +72,11 @@ _"Fixes #XXXX"_ for issue number XXXX.
### You have a solution ### You have a solution
Please be so kind as to [search](#use-the-search-luke) for any open issue already covering Please be so kind as to [search](#use-the-search-luke) for any open issue already covering
your [problem](#you-have-a-problem), and any pending PR covering your solution. your [problem](#you-have-a-problem), and any pending/merged/rejected PR covering your solution.
If the solution is already reported, try it out and +1 the pull request if the If the solution is already reported, try it out and +1 the pull request if the
solution works ok. On the other hand, if you think your solution is better, post solution works ok. On the other hand, if you think your solution is better, post
it so we can have both solutions to compare. it with a reference to the other one so we can have both solutions to compare.
If not, then go ahead and submit a PR. Please copy to anyone relevant (_eg_ plugin If not, then go ahead and submit a PR. Please copy to anyone relevant (_eg_ plugin
maintainers) by mentioning their GitHub handle (starting with `@`) in your message. maintainers) by mentioning their GitHub handle (starting with `@`) in your message.
@ -86,7 +86,7 @@ maintainers) by mentioning their GitHub handle (starting with `@`) in your messa
Please [do not](https://github.com/robbyrussell/oh-my-zsh/wiki/Themes#dont-send-us-your-theme-for-now) Please [do not](https://github.com/robbyrussell/oh-my-zsh/wiki/Themes#dont-send-us-your-theme-for-now)
send themes for now. send themes for now.
Please be so kind as to [search](#use-the-search-luke) for any pending PR covering or Please be so kind as to [search](#use-the-search-luke) for any pending/merged/rejected PR covering or
related to what you want to add. related to what you want to add.
If you find one, try it out and work with the author on a common solution. If you find one, try it out and work with the author on a common solution.