1
0
Fork 0
mirror of https://github.com/ohmyzsh/ohmyzsh.git synced 2024-11-12 08:50:08 +00:00

update: refactor and fix logic in check_for_upgrade.sh (#8939)

This commit is contained in:
Marc Cornellà 2020-06-09 19:38:08 +02:00 committed by GitHub
parent a2a83be982
commit 3c777ebf1b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 79 additions and 58 deletions

View file

@ -4,11 +4,6 @@ if [[ -z "$ZSH_CACHE_DIR" ]]; then
ZSH_CACHE_DIR="$ZSH/cache" ZSH_CACHE_DIR="$ZSH/cache"
fi fi
# Migrate .zsh-update file to $ZSH_CACHE_DIR
if [ -f ~/.zsh-update ] && [ ! -f ${ZSH_CACHE_DIR}/.zsh-update ]; then
mv ~/.zsh-update ${ZSH_CACHE_DIR}/.zsh-update
fi
# Check for updates on initial load... # Check for updates on initial load...
if [ "$DISABLE_AUTO_UPDATE" != "true" ]; then if [ "$DISABLE_AUTO_UPDATE" != "true" ]; then
env ZSH=$ZSH ZSH_CACHE_DIR=$ZSH_CACHE_DIR DISABLE_UPDATE_PROMPT=$DISABLE_UPDATE_PROMPT zsh -f $ZSH/tools/check_for_upgrade.sh env ZSH=$ZSH ZSH_CACHE_DIR=$ZSH_CACHE_DIR DISABLE_UPDATE_PROMPT=$DISABLE_UPDATE_PROMPT zsh -f $ZSH/tools/check_for_upgrade.sh

View file

@ -1,62 +1,88 @@
#!/usr/bin/env zsh # Migrate .zsh-update file to $ZSH_CACHE_DIR
if [[ -f ~/.zsh-update && ! -f "${ZSH_CACHE_DIR}/.zsh-update" ]]; then
zmodload zsh/datetime mv ~/.zsh-update "${ZSH_CACHE_DIR}/.zsh-update"
function _current_epoch() {
echo $(( $EPOCHSECONDS / 60 / 60 / 24 ))
}
function _update_zsh_update() {
echo "LAST_EPOCH=$(_current_epoch)" >! ${ZSH_CACHE_DIR}/.zsh-update
}
function _upgrade_zsh() {
env ZSH=$ZSH sh $ZSH/tools/upgrade.sh
# update the zsh file
_update_zsh_update
}
epoch_target=$UPDATE_ZSH_DAYS
if [[ -z "$epoch_target" ]]; then
# Default to old behavior
epoch_target=13
fi fi
# Cancel upgrade if the current user doesn't have write permissions for the # Cancel update if:
# oh-my-zsh directory. # - the automatic update is disabled.
[[ -w "$ZSH" ]] || return 0 # - the current user doesn't have write permissions nor owns the $ZSH directory.
# - git is unavailable on the system.
if [[ "$DISABLE_AUTO_UPDATE" = true ]] \
|| [[ ! -w "$ZSH" || ! -O "$ZSH" ]] \
|| ! command -v git &>/dev/null; then
return
fi
# Cancel upgrade if git is unavailable on the system
whence git >/dev/null || return 0
if mkdir "$ZSH/log/update.lock" 2>/dev/null; then function current_epoch() {
if [ -f ${ZSH_CACHE_DIR}/.zsh-update ]; then zmodload zsh/datetime
. ${ZSH_CACHE_DIR}/.zsh-update echo $(( EPOCHSECONDS / 60 / 60 / 24 ))
}
if [[ -z "$LAST_EPOCH" ]]; then function update_last-updated_file() {
_update_zsh_update echo "LAST_EPOCH=$(current_epoch)" >! "${ZSH_CACHE_DIR}/.zsh-update"
rmdir $ZSH/log/update.lock # TODO: fix later }
return 0
fi
epoch_diff=$(($(_current_epoch) - $LAST_EPOCH)) function update_ohmyzsh() {
if [ $epoch_diff -gt $epoch_target ]; then ZSH="$ZSH" sh "$ZSH/tools/upgrade.sh"
if [ "$DISABLE_UPDATE_PROMPT" = "true" ]; then update_last-updated_file
_upgrade_zsh }
else
echo "[Oh My Zsh] Would you like to update? [Y/n]: \c" () {
read line emulate -L zsh
if [[ "$line" == Y* ]] || [[ "$line" == y* ]] || [ -z "$line" ]; then
_upgrade_zsh local epoch_target mtime option LAST_EPOCH
else
_update_zsh_update # Remove lock directory if older than a day
zmodload zsh/datetime
zmodload -F zsh/stat b:zstat
if mtime=$(zstat +mtime "$ZSH/log/update.lock" 2>/dev/null); then
if (( (mtime + 3600 * 24) < EPOCHSECONDS )); then
command rm -rf "$ZSH/log/update.lock"
fi fi
fi
fi fi
else
# create the zsh file
_update_zsh_update
fi
rmdir $ZSH/log/update.lock # Check for lock directory
fi if ! command mkdir "$ZSH/log/update.lock" 2>/dev/null; then
return
fi
# Remove lock directory on exit. `return 1` is important for when trapping a SIGINT:
# The return status from the function is handled specially. If it is zero, the signal is
# assumed to have been handled, and execution continues normally. Otherwise, the shell
# will behave as interrupted except that the return status of the trap is retained.
trap "rm -rf '$ZSH/log/update.lock'; return 1" EXIT INT QUIT
# Create or update .zsh-update file if missing or malformed
if ! source "${ZSH_CACHE_DIR}/.zsh-update" 2>/dev/null || [[ -z "$LAST_EPOCH" ]]; then
update_last-updated_file
return
fi
# Number of days before trying to update again
epoch_target=${UPDATE_ZSH_DAYS:-13}
# Test if enough time has passed until the next update
if (( ( $(current_epoch) - $LAST_EPOCH ) < $epoch_target )); then
return
fi
# Ask for confirmation before updating unless disabled
if [[ "$DISABLE_UPDATE_PROMPT" = true ]]; then
update_ohmyzsh
else
# input sink to swallow all characters typed before the prompt
# and add a newline if there wasn't one after characters typed
while read -t -k 1 option; do true; done
[[ "$option" != ($'\n'|"") ]] && echo
echo -n "[oh-my-zsh] Would you like to update? [Y/n] "
read -r -k 1 option
[[ "$option" != $'\n' ]] && echo
case "$option" in
[nN]) update_last-updated_file ;;
*) update_ohmyzsh ;;
esac
fi
}
unset -f current_epoch update_last-updated_file update_ohmyzsh