2022-04-15 11:34:17 +00:00
|
|
|
"""Check for alias collisions within the codebase"""
|
|
|
|
|
2022-11-22 15:24:15 +00:00
|
|
|
from argparse import ArgumentDefaultsHelpFormatter, ArgumentParser
|
2022-04-15 11:34:17 +00:00
|
|
|
from pathlib import Path
|
2024-02-02 18:54:53 +00:00
|
|
|
from dataclasses import dataclass, asdict
|
2024-02-02 12:48:57 +00:00
|
|
|
from typing import List, Dict
|
2022-04-15 11:34:17 +00:00
|
|
|
import itertools
|
|
|
|
import re
|
2024-02-02 18:54:53 +00:00
|
|
|
import json
|
2022-04-15 11:34:17 +00:00
|
|
|
|
|
|
|
|
2022-11-22 16:57:15 +00:00
|
|
|
ERROR_MESSAGE_TEMPLATE = (
|
|
|
|
"Alias `%s` defined in `%s` already exists as alias `%s` in `%s`."
|
|
|
|
)
|
2022-04-15 11:34:17 +00:00
|
|
|
|
2024-02-02 18:54:53 +00:00
|
|
|
# TODO: We want that list to be empty and get rid of this file
|
|
|
|
KNOWN_COLLISIONS = Path(__file__).resolve().parent / "known_collisions.json"
|
2024-02-02 13:13:12 +00:00
|
|
|
|
2022-04-15 11:34:17 +00:00
|
|
|
|
|
|
|
def dir_path(path_string: str) -> Path:
|
|
|
|
if Path(path_string).is_dir():
|
|
|
|
return Path(path_string)
|
|
|
|
else:
|
|
|
|
raise NotADirectoryError(path_string)
|
|
|
|
|
|
|
|
|
|
|
|
def parse_arguments():
|
|
|
|
parser = ArgumentParser(
|
|
|
|
description=__doc__,
|
|
|
|
formatter_class=ArgumentDefaultsHelpFormatter,
|
|
|
|
)
|
|
|
|
parser.add_argument(
|
|
|
|
"folder",
|
|
|
|
type=dir_path,
|
|
|
|
help="Folder to check",
|
|
|
|
)
|
2024-02-02 18:54:53 +00:00
|
|
|
parser.add_argument(
|
|
|
|
"--known-collisions",
|
|
|
|
type=Path,
|
|
|
|
default=KNOWN_COLLISIONS,
|
|
|
|
help="Json-serialized list of known collisions",
|
|
|
|
)
|
2022-04-15 11:34:17 +00:00
|
|
|
return parser.parse_args()
|
|
|
|
|
|
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
|
|
class Alias:
|
|
|
|
|
|
|
|
alias: str
|
|
|
|
value: str
|
|
|
|
module: Path
|
|
|
|
|
|
|
|
|
2022-11-22 16:57:15 +00:00
|
|
|
@dataclass(frozen=True)
|
|
|
|
class Collision:
|
|
|
|
|
|
|
|
existing_alias: Alias
|
|
|
|
new_alias: Alias
|
|
|
|
|
2024-02-02 18:54:53 +00:00
|
|
|
def is_new_collision(self, known_collision_aliases: List[str]) -> bool:
|
|
|
|
return self.new_alias.alias not in known_collision_aliases
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
def from_dict(cls, collision_dict: Dict) -> "Collision":
|
|
|
|
return cls(
|
|
|
|
Alias(**collision_dict["existing_alias"]),
|
|
|
|
Alias(**collision_dict["new_alias"]),
|
|
|
|
)
|
2024-02-02 13:13:12 +00:00
|
|
|
|
2022-11-22 16:57:15 +00:00
|
|
|
|
2024-02-02 12:48:57 +00:00
|
|
|
def find_aliases_in_file(file: Path) -> List[Alias]:
|
2022-04-15 11:34:17 +00:00
|
|
|
matches = re.findall(r"^alias (.*)='(.*)'", file.read_text(), re.M)
|
|
|
|
return [Alias(match[0], match[1], file) for match in matches]
|
|
|
|
|
|
|
|
|
2024-02-02 18:54:53 +00:00
|
|
|
def load_known_collisions(collision_file: Path) -> List[Collision]:
|
|
|
|
collision_list = json.loads(collision_file.read_text())
|
|
|
|
return [Collision.from_dict(collision_dict) for collision_dict in collision_list]
|
|
|
|
|
|
|
|
|
2022-11-22 16:57:15 +00:00
|
|
|
def find_all_aliases(path: Path) -> list:
|
2024-02-02 13:13:12 +00:00
|
|
|
aliases = [find_aliases_in_file(file) for file in path.rglob("*.zsh")]
|
2022-04-15 11:34:17 +00:00
|
|
|
return list(itertools.chain(*aliases))
|
|
|
|
|
|
|
|
|
2024-02-02 12:48:57 +00:00
|
|
|
def check_for_duplicates(aliases: List[Alias]) -> List[Collision]:
|
2022-11-22 15:24:15 +00:00
|
|
|
elements = {}
|
2022-11-22 16:57:15 +00:00
|
|
|
collisions = []
|
2022-04-15 11:34:17 +00:00
|
|
|
for alias in aliases:
|
|
|
|
if alias.alias in elements:
|
|
|
|
existing = elements[alias.alias]
|
2022-11-22 16:57:15 +00:00
|
|
|
collisions.append(Collision(existing, alias))
|
|
|
|
else:
|
|
|
|
elements[alias.alias] = alias
|
|
|
|
return collisions
|
|
|
|
|
|
|
|
|
2024-02-02 12:48:57 +00:00
|
|
|
def print_collisions(collisions: Dict[Alias, Alias]) -> None:
|
2022-11-22 16:57:15 +00:00
|
|
|
if collisions:
|
|
|
|
print(f"Found {len(collisions)} alias collisions:\n")
|
|
|
|
for collision in collisions:
|
|
|
|
print(
|
2022-04-15 11:34:17 +00:00
|
|
|
ERROR_MESSAGE_TEMPLATE
|
|
|
|
% (
|
2022-11-22 16:57:15 +00:00
|
|
|
f"{collision.new_alias.alias}={collision.new_alias.value}",
|
|
|
|
collision.new_alias.module.name,
|
|
|
|
f"{collision.existing_alias.alias}={collision.existing_alias.value}",
|
|
|
|
collision.existing_alias.module.name,
|
2022-04-15 11:34:17 +00:00
|
|
|
)
|
|
|
|
)
|
2022-11-22 16:57:15 +00:00
|
|
|
print("\nConsider renaming your aliases.")
|
|
|
|
else:
|
|
|
|
print("Found no collisions")
|
2022-04-15 11:34:17 +00:00
|
|
|
|
|
|
|
|
2024-02-02 18:54:53 +00:00
|
|
|
def main() -> int:
|
2022-04-15 11:34:17 +00:00
|
|
|
"""main"""
|
|
|
|
args = parse_arguments()
|
|
|
|
aliases = find_all_aliases(args.folder)
|
2022-11-22 16:57:15 +00:00
|
|
|
collisions = check_for_duplicates(aliases)
|
2024-02-02 18:54:53 +00:00
|
|
|
|
|
|
|
known_collisions = load_known_collisions(args.known_collisions)
|
|
|
|
known_collision_aliases = [
|
|
|
|
collision.new_alias.alias for collision in known_collisions
|
|
|
|
]
|
|
|
|
|
2024-02-02 13:13:12 +00:00
|
|
|
new_collisions = [
|
|
|
|
collision
|
|
|
|
for collision in collisions
|
2024-02-02 18:54:53 +00:00
|
|
|
if collision.is_new_collision(known_collision_aliases)
|
2024-02-02 13:13:12 +00:00
|
|
|
]
|
2024-02-02 18:54:53 +00:00
|
|
|
|
2024-02-02 13:13:12 +00:00
|
|
|
print_collisions(new_collisions)
|
2024-02-02 18:54:53 +00:00
|
|
|
return -1 if new_collisions else 0
|
2022-04-15 11:34:17 +00:00
|
|
|
|
|
|
|
|
|
|
|
if __name__ == "__main__":
|
2024-02-02 18:54:53 +00:00
|
|
|
exit(main())
|